SNOW-1759084: Adjust aio telemetry events #2620
Open
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fpawlowski
approved these changes
Oct 31, 2025
| rets.extend(batch) | ||
| # yield to avoid blocking the event loop for too long when processing large result sets | ||
| # await asyncio.sleep(0) | ||
| await self._final() |
There was a problem hiding this comment.
I suppose not caring about the above comment is caused by the fact that user can just use 'async queries' - in Snowflake meaning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a difference in
fetchallimplementation between sync and aio code. In sync code thefetchallcallsfetchoneunder the hood. In AIO code the implementation is different and as a result does not call_report_metricsafter fetching all result.